Merged
Conversation
expand gt_group capability
Member
|
This looks great, thank you! Just going to make a few very small changes and I'll merge this right after that. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@rich-iannone very happy to iterate on this if you think it should live in its own function or you'd prefer it done in a different way. This functionality of being able to add gt_groups together into a new gt_group would be very helpful for us and doesn't seem to be covered right now with the grp_add or gt_group functions
Related GitHub Issues and PRs
Checklist
testthatunit tests totests/testthatfor any new functionality.